ci: place files at top-level of release archives #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To make this clearer - compare these two results: This is is the output when inspecting the tar from the 1.2.0 release: And this is from the tarball generated in the CI run for this PR: |
rebornplusplus
approved these changes
Aug 10, 2023
|
@jnsgruk Want me to re-upload the v1.2.0 binaries with this change, or should leave those and just wait till the next versioned release? |
|
@benhoyt i don't think so - should be fine to leave those :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from a conversation with @rebornplusplus which made me realise that our release archives actually create a tarball containing a directory named
.with the files within it.This change makes all the files appear at the top-level of the archive.